Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lib directory and replace it with granular utils_* subworkflows #2736

Merged
merged 27 commits into from
Feb 16, 2024
Merged

Remove lib directory and replace it with granular utils_* subworkflows #2736

merged 27 commits into from
Feb 16, 2024

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Feb 8, 2024 •
edited by mirpedrol
Loading

Some things left to do that I took note of and might be worth splitting up into separate issues:

  • Use MultiQC for software versions and remove custom/dumpsoftwareversions
  • Remove input_check.nf, check_samplesheet.py and samplesheet_check.nf and replace with nf-validation
  • Attach MultiQC report in completion email. This has been removed in the current implementation in this PR.
  • Add in methods description implementation. This has been removed in the current implementation in this PR.

Edit by @mashehu:
Not in the scope of this PR:

  • Move ALL subworkflows and workflows into their own named folder. See here
  • Remove modules.config and have individual nextflow.config file in component folders instead. See here
  • Do not remove nextflow.config when updating modules/subworkflows
  • Update Github Actions for cloud tests on AWS and Azure. See here and here

@drpatelh
Copy link
Member Author

drpatelh commented Feb 8, 2024

@mirpedrol I added a checkProfileProvided function in 5214976

We will need to update the relevant subworkflow in nf-core/modules.

@mirpedrol mirpedrol added this to the 2.13 milestone Feb 9, 2024
@mirpedrol mirpedrol mentioned this pull request Feb 9, 2024
Merged
@mirpedrol mirpedrol mentioned this pull request Feb 10, 2024
Merged
@drpatelh
Copy link
Member Author

drpatelh commented Feb 10, 2024 •
edited
Loading

@mashehu @mirpedrol not sure whether you plan to or are doing this already but I thought we could use nf-test to check the pipeline tests pass as part of the nf-core/tools tests. Then we just add different combinations of nf-core create with different components and run every nf-test found from the root folder downwards which will induce module/subworkflow/workflow/pipeline tests too.

Would like to have a quick chat with you both next week if you have some time. Ping me on Slack and we can sort out a time.

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fca9d74) 73.53% compared to head (28c0196) 73.46%.
Report is 60 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Feb 14, 2024
View reviewed changes
nf_core/pipeline-template/conf/test.config Outdated Show resolved Hide resolved
nf_core/create.py Outdated Show resolved Hide resolved
nf_core/pipeline-template/workflows/pipeline.nf Outdated Show resolved Hide resolved
mashehu
mashehu approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to run a few test runs locally, but I think it looks good

ewels
ewels reviewed Feb 15, 2024
View reviewed changes
nf_core/lint/files_exist.py Outdated Show resolved Hide resolved
nf_core/lint/files_exist.py Outdated Show resolved Hide resolved
@mirpedrol mirpedrol merged commit f016e45 into dev Feb 16, 2024
36 checks passed
@mirpedrol mirpedrol deleted the rm_lib branch February 16, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels left review comments

@mirpedrol mirpedrol mirpedrol approved these changes

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
4 participants
@drpatelh @ewels @mashehu @mirpedrol